[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 9 00:31:02 PDT 2020


eduucaldas marked 6 inline comments as done.
eduucaldas added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:618
+      Builder.foldNode(Builder.getRange(it.getLocalSourceRange()), NS, nullptr);
+      Builder.markChild(NS, syntax::NodeRole::Unknown);
+    }
----------------
gribozavr2 wrote:
> Do we need to mark the role if it is unknown?
> 
Thanks, that had slipped through, sorry for that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81168/new/

https://reviews.llvm.org/D81168





More information about the cfe-commits mailing list