[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 8 16:39:51 PDT 2020
efriedma added inline comments.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:11571
+ Diag(Loc,
+ getLangOpts().C11
+ ? diag::ext_typecheck_compare_complete_incomplete_pointers
----------------
I think this condition is backwards? Should be `!getLangOpts().C11`. You want the warning with `-std=c99 -pedantic`, you don't want the warning with `std=c11 -pedantic`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79945/new/
https://reviews.llvm.org/D79945
More information about the cfe-commits
mailing list