[PATCH] D81420: Fix size for _ExtInt types with builtins

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 8 13:52:08 PDT 2020


lebedev.ri added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:1747-1748
     break;
   case Builtin::BI__builtin_add_overflow:
   case Builtin::BI__builtin_sub_overflow:
   case Builtin::BI__builtin_mul_overflow:
----------------
I don't think this applies to `add`/`sub`: https://godbolt.org/z/Dj3GLP (or at least not all of them?)
OTOH this does apply to plain division/remainder: https://godbolt.org/z/SXNw8H


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81420/new/

https://reviews.llvm.org/D81420





More information about the cfe-commits mailing list