[PATCH] D81178: [FPEnv] Initialization of C++ globals not strictfp aware

Kevin P. Neal via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 8 11:02:56 PDT 2020


kpn marked an inline comment as done.
kpn added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.h:4348
+  /// Query for the use of constrained floating point math
+  bool isStrictFP() { return Builder.getIsFPConstrained(); }
+
----------------
rjmccall wrote:
> How is this set that we don't end up also setting it as a function attribute?
I admit I don't understand the question. Since the strictfp attribute is required on both definitions and calls then only one accessor function seems needed?

I don't get to spend as much time in clang proper as I might like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81178/new/

https://reviews.llvm.org/D81178





More information about the cfe-commits mailing list