[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

Mon Jun 8 10:30:14 PDT 2020

ychen added inline comments.

================
Comment at: clang/test/AST/sourceranges.cpp:116
+  void f() {
+    // CHECK: AttributedStmt {{.*}} <line:[[@LINE-3]]:24, line:[[@LINE+2]]:33>
+    DO_PRAGMA (unroll(2))
----------------
jdenny wrote:
> Is there any reason not to check for `LoopHintAttr` here and on the `_Pragma` case below?  If so, I suggest a comment to explain why these cases are different.
Comment added.

The existing checking of `LoopHintAttr` already covered the code changes in  `ParsePragma.cpp`. In the other two cases `LoopHintAttr` have its location in `<scratch space>` which I felt unrelated to this change so I skipped them to avoid confusion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80944/new/

https://reviews.llvm.org/D80944