[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

Mon Jun 8 10:30:10 PDT 2020

aprantl added a comment.

I was going to ask why make this change, but looking at the patch, it's pretty obvious :-)

================
Comment at: clang/include/clang/Basic/Module.h:29
 #include "llvm/ADT/iterator_range.h"
+#include <algorithm>
 #include <array>
----------------
Can you move the code that depends on algorithm into a .cpp file?

================
Comment at: clang/include/clang/Basic/Module.h:70
+
+  static ASTFileSignature createDISentinel() {
+    ASTFileSignature Sentinel;
----------------
dang wrote:
> I couldn't find anywhere in the code base that checks the bit-pattern so I left it as is. If anyone knows if someone could point me to the code that checks this (if any code does check it) that would be nice.
The PCM hash is reused in CGDebugInfo as the DW_AT_dwo_id hash for the -gmodules debug info. This value is checked by dsymutil and LLDB.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81347/new/

https://reviews.llvm.org/D81347