[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

[David Goldman via Phabricator via cfe-commits]

dgoldman added inline comments.


================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5199
+      // Objective-C property reference. Bail if we're performing fix-it code
+      // completion since we don't handle forwarding the fix-it for Objective-C
+      // objects. Since Objective-C properties are normally backed by ivars,
----------------
sammccall wrote:
> I don't really follow what the comment means by "forwarding the fixit". As I understood it, the issue is -> and . are likely both valid, so changing one to the other is confusing. Might be able to reword to clarify.
I meant the code previously would try give fix it code completions without marking it as a fix it. But I've gone ahead and removed it in favor of the other comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81263/new/

https://reviews.llvm.org/D81263