[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 8 08:48:37 PDT 2020
sammccall accepted this revision.
sammccall added a comment.
LG, thanks!
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5199
+ // Objective-C property reference. Bail if we're performing fix-it code
+ // completion since we don't handle forwarding the fix-it for Objective-C
+ // objects. Since Objective-C properties are normally backed by ivars,
----------------
I don't really follow what the comment means by "forwarding the fixit". As I understood it, the issue is -> and . are likely both valid, so changing one to the other is confusing. Might be able to reword to clarify.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81263/new/
https://reviews.llvm.org/D81263
More information about the cfe-commits
mailing list