[PATCH] D81388: [TEST] TreeTest.cpp - Add a comma to avoid build error with -werror
Kan Shengchen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 8 07:05:25 PDT 2020
skan created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
skan added reviewers: gribozavr, hlopko, eduucaldas.
The macro `INSTANTIATE_TEST_CASE_P` is defined as
\# define INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator, ...) \
...
If we build the test case with -werror, we will get an error like
error: ISO C++11 requires at least one argument for the "..." in a
variadic macro
testing::ValuesIn(TestClangConfig::allConfigs()));
^
This patch fixes that.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D81388
Files:
clang/unittests/Tooling/Syntax/TreeTest.cpp
Index: clang/unittests/Tooling/Syntax/TreeTest.cpp
===================================================================
--- clang/unittests/Tooling/Syntax/TreeTest.cpp
+++ clang/unittests/Tooling/Syntax/TreeTest.cpp
@@ -2995,6 +2995,6 @@
}
INSTANTIATE_TEST_CASE_P(SyntaxTreeTests, SyntaxTreeTest,
- testing::ValuesIn(TestClangConfig::allConfigs()));
+ testing::ValuesIn(TestClangConfig::allConfigs()), );
} // namespace
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81388.269208.patch
Type: text/x-patch
Size: 472 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200608/f9cfd081/attachment.bin>
More information about the cfe-commits
mailing list