[PATCH] D81154: [AST][RecoveryExpr] Populate the dependence bits from CompoundStmt result expr to StmtExpr.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 8 06:31:10 PDT 2020


hokein added inline comments.


================
Comment at: clang/lib/AST/ComputeDependence.cpp:132
   // FIXME: why is unexpanded-pack not propagated?
   auto D = toExprDependence(E->getType()->getDependence()) &
            ~ExprDependence::UnexpandedPack;
----------------
sammccall wrote:
> I wonder if this is still needed - how can we get a type for the stmtexpr unless we have a result expr providing the type?
it is possible that the stmtexpr has a type and doesn't have a result expr, e.g `({ if (1) {}; })`, the default type is `void`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81154/new/

https://reviews.llvm.org/D81154





More information about the cfe-commits mailing list