[PATCH] D80723: [PowerPC] Convert vec_splats functions to macros

Qing Shan Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 7 18:39:36 PDT 2020


steven.zhang added a comment.

It LGTM now except one comment on the test. And it seems that, we still have many other builtins implementation that didn't use the _Generic.



================
Comment at: clang/test/CodeGen/ppc-emmintrin.c:1
-// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
 // REQUIRES: powerpc-registered-target
----------------
So, why this line of comments is removed ? It seems that, the old test was generated by the script while the new one isn't. I expect both should generate by script. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80723/new/

https://reviews.llvm.org/D80723





More information about the cfe-commits mailing list