[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

Daniel Grumberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 7 12:14:54 PDT 2020


dang created this revision.
dang added reviewers: aprantl, dexonsmith, Bigcheese.
Herald added subscribers: cfe-commits, arphaman.
Herald added a project: clang.
dang marked an inline comment as done.
dang added inline comments.


================
Comment at: clang/include/clang/Basic/Module.h:70
+
+  static ASTFileSignature createDISentinel() {
+    ASTFileSignature Sentinel;
----------------
I couldn't find anywhere in the code base that checks the bit-pattern so I left it as is. If anyone knows if someone could point me to the code that checks this (if any code does check it) that would be nice.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81347

Files:
  clang/include/clang/Basic/Module.h
  clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTWriter.cpp
  clang/lib/Serialization/GlobalModuleIndex.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81347.269069.patch
Type: text/x-patch
Size: 6664 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200607/3e6e7eeb/attachment.bin>


More information about the cfe-commits mailing list