[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 6 13:53:11 PDT 2020


fhahn added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:12130
+  QualType LHSType = LHS.get()->getType().getUnqualifiedType();
+  QualType RHSType = RHS.get()->getType().getUnqualifiedType();
+
----------------
rjmccall wrote:
> You never actually do anything with these that cares about having gotten the unqualified type.
Ah right! I think that was still a left-over from the manual conversion code. Dropped!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76794/new/

https://reviews.llvm.org/D76794





More information about the cfe-commits mailing list