[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 5 14:03:26 PDT 2020


efriedma added inline comments.


================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:666
+    FirstNonOverlappingEmptyFieldHandled
+  } FirstNonOverlappingEmptyFieldStatus;
+
----------------
Instead of specifically tracking whether you've found an OverlappingEmpty field, could you just have something like "bool FoundNonOverlappingEmptyField = false;", and set it to true when you handle a field that isn't OverlappingEmpty?  I don't think we need to specifically track whether we've found an OverlappingEmpty field.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79719/new/

https://reviews.llvm.org/D79719





More information about the cfe-commits mailing list