[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added a comment.

In D81192#2074677 <https://reviews.llvm.org/D81192#2074677>, @mikerice wrote:

> Is it possible to have the same problem with other directives, like 'omp single' or 'omp master'?  I haven't seen any test fail for those yet though.


I rather doubt. The main problem with the critical directive that load/stores should not be moved out of the region (they all should be executed in the critical region context, just like atomics). For single and master it should be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81192/new/

https://reviews.llvm.org/D81192