[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 4 11:33:41 PDT 2020


MaskRay added a comment.

Drive-by comment: the clang side change isn't tightly coupled with the LLVM side changes. It should be a separate patch.



================
Comment at: llvm/test/MC/RISCV/rvv/add.s:1
+# RUN: llvm-mc -triple=riscv64 -show-encoding --mattr=+experimental-v < %s \
+# RUN:        | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST
----------------
`< %s` -> `%s`

ditto for every other test.

A check prefix does not have to start with `CHECK-`.
If shortening the prefix can avoid wrapped lines, probably worth considering it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69987/new/

https://reviews.llvm.org/D69987





More information about the cfe-commits mailing list