[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 4 11:33:30 PDT 2020


gribozavr2 marked an inline comment as done.
gribozavr2 added inline comments.


================
Comment at: clang/unittests/ASTMatchers/ASTMatchersTest.h:62
+inline ArrayRef<TestLanguage> langCxx11OrLater() {
+  static std::vector<TestLanguage> Result = {Lang_CXX11, Lang_CXX14, Lang_CXX17,
+                                             Lang_CXX20};
----------------
njames93 wrote:
> Bit late, but surely these should have been const arrays instead of vectors.
Thanks! https://reviews.llvm.org/D81180


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81150/new/

https://reviews.llvm.org/D81150





More information about the cfe-commits mailing list