[PATCH] D81157: Propose naming principle for NodeRole and apply it

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr2 added inline comments.


================
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:110
+/// BinaryOperatorExpression_leftHandSide can only appear as a child of a
+/// BinaryOperatorExpression node.end with `NodeKind_` of the parent
 enum class NodeRole : uint8_t {
----------------
There are some leftovers of old text after the period.


================
Comment at: clang/lib/Tooling/Syntax/Nodes.cpp:154
+  case syntax::NodeRole::ArrowToken:
+    return OS << "ArrowToken";
   case syntax::NodeRole::TrailingReturnType_declarator:
----------------
Please reorder.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81157/new/

https://reviews.llvm.org/D81157