[PATCH] D81168: Add support for id-expression in SyntaxTree

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 4 09:20:46 PDT 2020


eduucaldas added inline comments.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:829
+    | | | | | `-::
+    | | | | `-TypeSpecifier
+    | | | |   |-S
----------------
eduucaldas wrote:
> Perhaps we shouldn't differ between specifiers as that is semantical information
Followed the [[ https://eel.is/c++draft/expr.prim.id.qual | grammar ]], but added specifier in the end as we also hold the `::` and not only the names


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81168/new/

https://reviews.llvm.org/D81168





More information about the cfe-commits mailing list