[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 4 04:50:38 PDT 2020


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:718
+}
+    )cpp",
+      R"txt(
----------------
Could you remove the whitespace in front of `)cpp"` for consistency with the rest of the file?


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:758
+
+TEST_P(SyntaxTreeTest, LongLongLiteral) {
+  if (!GetParam().isCXX11OrLater()) {
----------------
IntegerLiteralLongLong


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:792
+
+TEST_P(SyntaxTreeTest, BinaryLiteral) {
+  if (!GetParam().isCXX14OrLater()) {
----------------
IntegerLiteralBinary


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:821
+
+TEST_P(SyntaxTreeTest, QuotedIntegerLiteral) {
+  if (!GetParam().isCXX14OrLater()) {
----------------
IntegerLiteralWithDigitSeparators


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81135/new/

https://reviews.llvm.org/D81135





More information about the cfe-commits mailing list