[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

[Simon Moll via Phabricator via cfe-commits]

simoll marked 2 inline comments as done.
simoll added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4710
     if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) {
-      auto *Vec4Ty = llvm::FixedVectorType::get(
+      auto Vec4Ty = llvm::VectorType::get(
           cast<llvm::VectorType>(DstTy)->getElementType(), 4);
----------------
Accidental change. Will undo.


================
Comment at: clang/lib/CodeGen/CGRecordLayoutBuilder.cpp:590
+  CharUnits Tail =
+      getSize(Prior->Data); // FIXME assumes `i8` multiples for boolean vector!
   for (std::vector<MemberInfo>::iterator Member = Prior + 1,
----------------
This is an old comment that is no longer helpful. Will remove.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81083/new/

https://reviews.llvm.org/D81083