[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 4 02:07:54 PDT 2020


gribozavr2 added inline comments.


================
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190
+  }
+  syntax::Leaf *literal();
+};
----------------
"literalToken"?


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:706
+void test() {
+  42;
+}
----------------
Please add more tests for integers with suffixes (0u, 0ll etc.), different bases (hex, octal etc.), digit separators.

http://eel.is/c++draft/lex.icon
https://en.cppreference.com/w/cpp/language/integer_literal



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81135/new/

https://reviews.llvm.org/D81135





More information about the cfe-commits mailing list