[PATCH] D59520: [WebAssembly] Address review comments on r352930

Dan Gohman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 3 16:35:30 PDT 2020


sunfish updated this revision to Diff 268329.
sunfish added a comment.

- Add tests for redeclaration behavior
- Remove disabled tests (previously marked with FIXMEs)
- Made the mismatch warning more informative.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59520/new/

https://reviews.llvm.org/D59520

Files:
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Sema/Sema.h
  clang/lib/Sema/SemaDecl.cpp
  clang/lib/Sema/SemaDeclAttr.cpp
  clang/test/AST/ast-dump-wasm-attr-export.c
  clang/test/AST/ast-dump-wasm-attr-import.c
  clang/test/Sema/attr-wasm.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59520.268329.patch
Type: text/x-patch
Size: 11413 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200603/30aae59d/attachment-0001.bin>


More information about the cfe-commits mailing list