[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 3 16:35:28 PDT 2020


jdoerfert added a subscriber: RaviNarayanaswamy.
jdoerfert added a comment.

I was hoping @dreachem and maybe @RaviNarayanaswamy would look at this.



================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7630
+        // OMPC_MAP_MODIFIER_last is used to identify data members used in
+        // used_device_adddr clause.
+        bool IsMemberPointerOrAddr =
----------------
jdoerfert wrote:
> I'm not a fan of this implicit encoding. Can't we add a new map type or modifier?
Better, thanks. The comment change is probably not needed anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80730/new/

https://reviews.llvm.org/D80730





More information about the cfe-commits mailing list