[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 3 14:20:39 PDT 2020


ABataev marked an inline comment as done.
ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14900
         }
-        continue;
       }
----------------
jdoerfert wrote:
> Why would we continue after this error?
The function, that uses VLAs, might be processed in Sema, but not actually used (and, thus, is not emitted and the error message won't be generated). Need to continue the normal processing as if the error is not emitted. If we leave `continue` in the old place, the list of the reduction variables might be empty and in this case, the reduction clause won't be built. The `scan` directive then diagnoses that it does not see a single reduction clause with the `inscan` modifier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79948/new/

https://reviews.llvm.org/D79948





More information about the cfe-commits mailing list