[PATCH] D81115: [PowerPC] Do not check for non-Darwin in PowerPC target cpu handling

Steven Wan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 3 13:11:23 PDT 2020


stevewan created this revision.
Herald added subscribers: cfe-commits, steven.zhang, shchenz, nemanjai.
Herald added a project: clang.
stevewan added reviewers: hubert.reinterpretcast, daltenty.
Herald added a subscriber: wuzish.

Since Darwin on PowerPC is no longer supported, we'll take the Darwin factor out from the code that determines the default target cpu on PowerPC.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81115

Files:
  clang/lib/Driver/ToolChains/CommonArgs.cpp


Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
===================================================================
--- clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -294,18 +294,16 @@
     std::string TargetCPUName = ppc::getPPCTargetCPU(Args);
     // LLVM may default to generating code for the native CPU,
     // but, like gcc, we default to a more generic option for
-    // each architecture. (except on AIX or Darwin)
+    // each architecture. (except on AIX)
     if (TargetCPUName.empty()) {
       if (T.isOSAIX())
         TargetCPUName = "pwr4";
-      else if (!T.isOSDarwin()) {
-        if (T.getArch() == llvm::Triple::ppc64)
-          TargetCPUName = "ppc64";
-        else if (T.getArch() == llvm::Triple::ppc64le)
-          TargetCPUName = "ppc64le";
-        else
-          TargetCPUName = "ppc";
-      }
+      else if (T.getArch() == llvm::Triple::ppc64)
+        TargetCPUName = "ppc64";
+      else if (T.getArch() == llvm::Triple::ppc64le)
+        TargetCPUName = "ppc64le";
+      else
+        TargetCPUName = "ppc";
     }
     return TargetCPUName;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81115.268286.patch
Type: text/x-patch
Size: 1139 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200603/c43ea3a9/attachment-0001.bin>


More information about the cfe-commits mailing list