[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 3 12:05:45 PDT 2020


arsenm added inline comments.


================
Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:290
   assert(DataLayout->getAllocaAddrSpace() == Private);
+  GridValues = &(llvm::GPU::AMDGPUGpuGridValues[0]);
+  LongGridValues = &(llvm::GPU::AMDGPUGpuLongGridValues[0]);
----------------
Don't need parentheses


================
Comment at: clang/lib/Basic/Targets/NVPTX.cpp:66
   AddrSpaceMap = &NVPTXAddrSpaceMap;
+  GridValues = &(llvm::GPU::NVPTXGpuGridValues[0]);
+  LongGridValues = &(llvm::GPU::NVPTXGpuLongGridValues[0]);
----------------
Don't need parentheses


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80917/new/

https://reviews.llvm.org/D80917





More information about the cfe-commits mailing list