[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 3 12:05:38 PDT 2020


jhuber6 added a comment.

I'm just investigating migrating D80222 <https://reviews.llvm.org/D80222> away from the static methods. When I try to just add an OpenMPIRBuilder type and initialize it I get failures on the tests. I'm just adding in the module as you have 
`CGOpenMPRuntime.h`

  llvm::OpenMPIRBuilder InternalOMPBuilder;

`CGOpenMPRuntime.cpp`

  CGOpenMPRuntime::CGOpenMPRuntime(CodeGenModule &CGM, StringRef FirstSeparator,
                                   StringRef Separator)
      : CGM(CGM), FirstSeparator(FirstSeparator), Separator(Separator),
        InternalOMPBuilder(CGM.getModule()), OffloadEntriesInfoManager(CGM) {
    InternalOMPBuilder.initialize();

But it causes most of the tests to fail even without using the IRBuilder object.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80735/new/

https://reviews.llvm.org/D80735





More information about the cfe-commits mailing list