[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

Adrian McCarthy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 3 08:45:21 PDT 2020


amccarth added a comment.

Please make sure all of the clang VFS tests still pass before submitted this.  VFS paths are inherently problematic with `llvm::sys::path` because they can legitimately be in a hybrid of Windows and Posix styles.  Guessing the style from the first separator you see can be misleading, but I don't know whether that's ever wrong in this path.

Exactly which assertion is firing?  Is it possible it's the assertion that's wrong?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81041/new/

https://reviews.llvm.org/D81041





More information about the cfe-commits mailing list