[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

[Adrian McCarthy via Phabricator via cfe-commits]

amccarth added a comment.

In D80833#2069874 <https://reviews.llvm.org/D80833#2069874>, @thakis wrote:

> The change description says something about PWD


I believe that was a typo for CWD.

> Please don't add code that stores absolute paths, but at the moment this doesn't do that as far as I can tell :)

Ah, but the summary suggests that it is:

> The LF_BUILDINFO therefore stores a full path to the compiler....

>From what I see, it's storing Args[0], which is usually the program name as specified on the command line.  If a build system is using full paths in the commands, I think they will be stored.



================
Comment at: clang/test/CodeGen/debug-info-codeview-buildinfo.c:8
+// CHECK: ============================================================
+// CHECK: 0x[[PWD:.+]] | LF_STRING_ID [size = {{.+}}] ID: <no type>, String: [[PWDVAL:.+]]
+// CHECK: 0x[[FILEPATH:.+]] | LF_STRING_ID [size = {{.+}}] ID: <no type>, String: [[FILEPATHVAL:.+[\\/]debug-info-codeview-buildinfo.c]]
----------------
PWD?  Did you mean CWD (current working directory)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80833/new/

https://reviews.llvm.org/D80833