[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

Tested with turning on `-frecovery-ast`, 3 failures, all of them are diagnostic improvements!

  FAIL: Clang :: SemaCXX/constant-expression-cxx11.cpp (10868 of 18440)
  ******************** TEST 'Clang :: SemaCXX/constant-expression-cxx11.cpp' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /workspace/llvm-project/build/bin/clang -cc1 -internal-isystem /workspace/llvm-project/build/lib/clang/11.0.0/include -nostdsysteminc -triple x86_64-linux -Wno-string-plus-int -Wno-pointer-arith -Wno-zero-length-array -Wno-c99-designator -fsyntax-only -fcxx-exceptions -verify -std=c++11 -pedantic /workspace/llvm-project/clang/test/SemaCXX/constant-expression-cxx11.cpp -Wno-comment -Wno-tautological-pointer-compare -Wno-bool-conversion
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  error: 'warning' diagnostics expected but not seen: 
    File /workspace/llvm-project/clang/test/SemaCXX/constant-expression-cxx11.cpp Line 2050: initialize all members
  error: 'note' diagnostics expected but not seen: 
    File /workspace/llvm-project/clang/test/SemaCXX/constant-expression-cxx11.cpp Line 2053: not initialized
  2 errors generated.
  
  --
  
  ********************
  FAIL: Clang :: SemaCXX/cxx0x-initializer-constructor.cpp (10884 of 18440)
  ******************** TEST 'Clang :: SemaCXX/cxx0x-initializer-constructor.cpp' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /workspace/llvm-project/build/bin/clang -cc1 -internal-isystem /workspace/llvm-project/build/lib/clang/11.0.0/include -nostdsysteminc -std=c++0x -fsyntax-only -fexceptions -verify /workspace/llvm-project/clang/test/SemaCXX/cxx0x-initializer-constructor.cpp
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  error: 'error' diagnostics seen but not expected: 
    File /workspace/llvm-project/clang/test/SemaCXX/cxx0x-initializer-constructor.cpp Line 166: expected ';' after expression
  1 error generated.
  
  --
  
  ********************
  FAIL: Clang :: SemaCXX/cxx1z-copy-omission.cpp (10915 of 18440)
  ******************** TEST 'Clang :: SemaCXX/cxx1z-copy-omission.cpp' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /workspace/llvm-project/build/bin/clang -cc1 -internal-isystem /workspace/llvm-project/build/lib/clang/11.0.0/include -nostdsysteminc -std=c++1z -verify -Wno-unused /workspace/llvm-project/clang/test/SemaCXX/cxx1z-copy-omission.cpp
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  error: 'error' diagnostics seen but not expected: 
    File /workspace/llvm-project/clang/test/SemaCXX/cxx1z-copy-omission.cpp Line 109: you need to include <typeinfo> before using the 'typeid' operator
  1 error generated.
  
  --
  
  ********************
  ********************
  Failing Tests (3):
    Clang :: SemaCXX/constant-expression-cxx11.cpp
    Clang :: SemaCXX/cxx0x-initializer-constructor.cpp
    Clang :: SemaCXX/cxx1z-copy-omission.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81090/new/

https://reviews.llvm.org/D81090