[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1108
+      std::move(CI),
+      !CompletingInPreamble ? &(Input.Preamble.Preamble) : nullptr,
       std::move(ContentsBuffer), std::move(VFS), IgnoreDiags);
----------------
sammccall wrote:
> this change looks suspicious, really needed?
oops, I think this is an accident change, reverted.


================
Comment at: clang-tools-extra/clangd/Compiler.h:57
   const SymbolIndex *Index = nullptr;
-  ParseOptions Opts;
+  ParseOptions Opts = ParseOptions();
 };
----------------
sammccall wrote:
> this is the default already - only need to do this for scalar types that would otherwise have indeterminate default
yeah, exactly, however clang was not happy with the `ParseInputs {Command, FS, contents}` usage, it gave `-Wmissing-field-initializers` warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81066/new/

https://reviews.llvm.org/D81066