[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

Wed Jun 3 06:00:21 PDT 2020

miyuki added inline comments.

================
Comment at: clang/include/clang/Basic/arm_neon.td:1860
+
+  def VGET_HIGH_BF : NoTestOpInst<"vget_high", ".Q", "b", OP_HI>;
+  def VGET_LOW_BF  : NoTestOpInst<"vget_low", ".Q", "b", OP_LO>;
----------------
dmgreen wrote:
> Do you know what InstName = "vmov" does, and is it needed here?
> 
> I'm pretty sure it's a vestige of an earlier implementation of the neon emitter.
It looks like `InstName` was removed from NeonEmitter in
```
commit dee4ab08ba956efd76aa10da46510dcddecceacf
Author: James Molloy <james.molloy at arm.com>
Date:   Tue Jun 17 13:11:27 2014 +0000

    Rewrite ARM NEON intrinsic emission completely.
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79710/new/

https://reviews.llvm.org/D79710