[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

Tue Jun 2 17:35:13 PDT 2020

jdoerfert added a comment.

In D79744#2069786 <https://reviews.llvm.org/D79744#2069786>, @arsenm wrote:

> In D79744#2069774 <https://reviews.llvm.org/D79744#2069774>, @arsenm wrote:
>
> > I think this is converging to adding a new IR attribute that essentially just provides the pointee type for ABI purposes. I guess my name ideas for this would be  "indirect", "value", "memoryvalue", "abitype"?
>
>
> My main question for a new attribute is whether it needs to be explicitly read only. I think the answer is no, since you can't ordinarily write to any random pointer argument

I think this is "in practice" correct (assuming you don't see a write to that location in which case you can do some crazy stuff).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79744/new/

https://reviews.llvm.org/D79744