[PATCH] D80876: [clang] Default to windows response files when running on windows

Tue Jun 2 14:18:02 PDT 2020

mstorsjo added a subscriber: mati865.
mstorsjo added a comment.

In D80876#2069418 <https://reviews.llvm.org/D80876#2069418>, @sbc100 wrote:

> If we want want to have the default on windows be dependent on mingw vs not-mingw then we should do it across the board so it applies to llvm-ar, lld, and other tools.  Right now I don't think any of those other tools have any special mingw handling.

That's a fair point

> Would it make sense to expect mingw users to explicitly pass `--rsp-quoting=gnu`.  I'm not very familiar with mingw use cases so I don't know if that is an unreadable request?

It'd be quite a bit of a hassle - one of the main points is to be able to build the vast majority of projects with unix style build systems, so anything that requires changes to the build systems is a hassle. That'd require either adding wrapper executables that pass such defaults (msys2 currently don't use anything such), or being able to configure custom defaults in the build (like one can set the default target or default linker etc).

If the practical failure cases only show up with response files with "tricky" filenames containing single quotes or similar, I guess it might be an option to just change the defaults (as you say, other tools already do it this way) and require changes only in projects that use problematic file names.

@mati865 What do you think, from the msys2 point of view?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80876/new/

https://reviews.llvm.org/D80876