[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

Chi Chun Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 2 12:37:56 PDT 2020


cchen added a comment.

In D79972#2069358 <https://reviews.llvm.org/D79972#2069358>, @ABataev wrote:

> In D79972#2069322 <https://reviews.llvm.org/D79972#2069322>, @cchen wrote:
>
> > In D79972#2068976 <https://reviews.llvm.org/D79972#2068976>, @ABataev wrote:
> >
> > > Still: Did you think about implementing it in the compiler instead of the runtime?
> >
> >
> > I'm not sure I understand your question, which part of code are you asking?
> >  The main work compiler needs to do is to send the {offset, count, stride} struct to runtime.
>
>
> I mean did you think about calling `__tgt_target_data_update` function in a loop in the compiler-generated code instead of putting it into the runtime?


Oh, I would prefer to call `tgt_target_data_update` once in the compiler and I'm also doing it now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79972/new/

https://reviews.llvm.org/D79972





More information about the cfe-commits mailing list