[PATCH] D80988: [clangd] Copy existing includes in ReplayPreamble

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:386
     // Replay the preamble includes so that clang-tidy checks can see them.
     ReplayPreamble::attach(Includes, *Clang, Preamble->Preamble.getBounds());
   }
----------------
it seems like it would be clearer to pass Preamble->preambleIncludes() here, at this point?
(And move within the constructor, so still just one copy)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80988/new/

https://reviews.llvm.org/D80988