[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

Dmitry Polukhin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 2 03:19:16 PDT 2020


DmitryPolukhin added reviewers: Eugene.Zelenko, thegameg.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added subscribers: thegameg, Eugene.Zelenko.
DmitryPolukhin added a comment.

+ @gribozavr, @Eugene.Zelenko, @thegameg who touched/reviewed this code, please take a look.



================
Comment at: llvm/lib/Support/YAMLTraits.cpp:904
+                                           std::string &Val) {
+  Val.clear();
+  size_t CurrentPos = 0;
----------------
mgehre wrote:
> I wonder whether using StringRef::split() would lead to an easier implementation (https://llvm.org/doxygen/classllvm_1_1StringRef.html#af0284e4c41c0e09c0bc4767bc77a899d)
I'm not sure that it will be easier to read or more efficient (`StringRef::split` will require additional vector).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80301/new/

https://reviews.llvm.org/D80301





More information about the cfe-commits mailing list