[PATCH] D80822: Run syntax tree tests in many language modes

[Eduardo Caldas via Phabricator via cfe-commits]

eduucaldas added inline comments.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:54-63
+  bool isCXX() const {
+    return Language == Lang_CXX || Language == Lang_CXX11 ||
+           Language == Lang_CXX14 || Language == Lang_CXX17 ||
+           Language == Lang_CXX2a;
+  }
+
+  bool isCXX11OrLater() const {
----------------
These could be on the clang/Testing


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:181
+
+    Invocation = createInvocationFromCommandLine(ArgsCStr, Diags, FS);
     assert(Invocation);
----------------
Note: This already adds -fsyntax-only as a flag


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:206
   void expectTreeDumpEqual(StringRef Code, StringRef Tree,
                            bool RunWithDelayedTemplateParsing = true) {
+    SCOPED_TRACE(llvm::join(GetParam().getCommandLineArgs(), " "));
----------------
is RunWithDelayedTemplateParsing being used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80822/new/

https://reviews.llvm.org/D80822