[PATCH] D80980: [AST] Fix a null initializer crash for InitListExpr

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 2 00:31:22 PDT 2020


hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clang/lib/Sema/SemaInit.cpp:1640
   expr = Result.getAs<Expr>();
   // FIXME: Why are we updating the syntactic init list?
+  if (!VerifyOnly && expr)
----------------
I have the same question.

but if you looked at the other 2 places (same FIXME) of this file, they reset the `Init` only when the `Result` is valid. I think this place maybe an overlook.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80980/new/

https://reviews.llvm.org/D80980





More information about the cfe-commits mailing list