[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 1 17:54:02 PDT 2020


rnk created this revision.
rnk added a reviewer: akhuang.
Herald added a reviewer: MaskRay.
Herald added a project: clang.
rnk updated this revision to Diff 267767.
rnk added a comment.

- revert lld change


Clang marks calls to operator new as heap allocation sites, but the
operator declared at global scope returns void. There is no explicit
cast in the code, so the compiler has to write down the allocated type
itself.

Also generalize a cast to use CallBase, so that we mark heap alloc sites
when exceptions are enabled.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80966

Files:
  clang/lib/CodeGen/CGCall.cpp
  clang/lib/CodeGen/CGDebugInfo.cpp
  clang/lib/CodeGen/CGDebugInfo.h
  clang/lib/CodeGen/CGExprCXX.cpp
  clang/lib/CodeGen/CGExprScalar.cpp
  clang/test/CodeGen/debug-info-codeview-heapallocsite.c
  clang/test/CodeGenCXX/debug-info-codeview-heapallocsite.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80966.267767.patch
Type: text/x-patch
Size: 6626 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200602/ae16dc7a/attachment.bin>


More information about the cfe-commits mailing list