[PATCH] D80876: [clang] Default to windows response files when running on windows

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 1 09:39:29 PDT 2020


probinson added inline comments.


================
Comment at: clang/tools/driver/driver.cpp:391
+    if (ClangCLMode ||
+        llvm::Triple(llvm::sys::getProcessTriple()).isOSWindows())
+      Tokenizer = &llvm::cl::TokenizeWindowsCommandLine;
----------------
Testing the triple is a functional change.  I should think the test for CL mode is sufficient.  Note that for PS4 we run on Windows but use a GNU-compatible command line and response-file style.  If you want Windows-style on Windows, invoke the compiler as "clang-cl" instead of "clang".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80876/new/

https://reviews.llvm.org/D80876





More information about the cfe-commits mailing list