[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

Mon Jun 1 06:55:53 PDT 2020

stuij marked 2 inline comments as done.
stuij added inline comments.

================
Comment at: clang/lib/Basic/Targets/ARM.cpp:80
     DoubleAlign = LongLongAlign = LongDoubleAlign = SuitableAlign = 32;
+  BFloat16Width = BFloat16Align = 16;
+  BFloat16Format = &llvm::APFloat::BFloat();
----------------
SjoerdMeijer wrote:
> Is this tested? Can it be tested?
Yes, I think it's a bit tricky to test this all by itself. Right now this is used when return a TypeInfo, which is used in all kinds of different contexts. I think alignment is better tested where it is eventually expressed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76077/new/

https://reviews.llvm.org/D76077