[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman marked 3 inline comments as done.
aaron.ballman added inline comments.


================
Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:65
-    bool Unset;
-    K = Spelling.getValueAsBitOrUnset("KnownToGCC", Unset);
   }
----------------
erichkeane wrote:
> aaron.ballman wrote:
> > erichkeane wrote:
> > > Doesn't this result in 'K' being uninitialized now?  
> > `K` is still being initialized by the ctor init list above on line 56.
> Isn't that in a different constructor?
Yes, yes it is. :-D Thank you for helping to point that out. I've fixed in the latest patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80836/new/

https://reviews.llvm.org/D80836