[PATCH] D80905: [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 1 06:23:39 PDT 2020


Szelethus added a comment.

>> checker callback evaluation order is ensured
> 
> And it will be the same for all callbacks, right? Like, we're not doing this thing yet where it intentionally goes like
> 
>   chk1->checkPreCall();
>   chk2->checkPreCall();
>   chk2->checkPostCall();
>   chk1->checkPostCall();
> 
> 
> ?

It should work for all callbacks. It'd be a nightmare to test and `assert`, but when `CheckerManager` registers a checker, all of its callbacks are registered to the appropriate container, which isn't sorted.

> NoQ added a reviewer: vsavchenko.

Woops O:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80905/new/

https://reviews.llvm.org/D80905





More information about the cfe-commits mailing list