[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 30 11:07:39 PDT 2020


njames93 accepted this revision.
njames93 added a comment.

LGMT, just a few minor nits though.



================
Comment at: clang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp:15-16
+#include "clang/Frontend/CompilerInstance.h"
+#include <algorithm>
+#include <string>
+
----------------
Fairly certain these headers aren't used


================
Comment at: clang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.h:30
+  bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
+    return LangOpts.CPlusPlus;
+  }
----------------
`std::all_of`, `std::any_of` and `std::none_of` were only introduced in c++11, maybe `CPlusPlus11` should be the minimum requirement.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:202
 -------------------------------
-
----------------
This removed line in unrelated and should be added back


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77572/new/

https://reviews.llvm.org/D77572





More information about the cfe-commits mailing list