[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

Fri May 29 14:14:30 PDT 2020

aprantl added inline comments.

================
Comment at: clang/test/Modules/ModuleDebugInfo.m:46-47

-// The forward declaration should not be in the module scope.
-// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "OpaqueData", file
-
----------------
dblaikie wrote:
> djtodoro wrote:
> > dblaikie wrote:
> > > Did this type go missing with this change? (ie: was this type /only/ accessible via a subprogram in the retained types list?)
> > Yes, it was **only** accessible via that subprogram we removed.
> @aprantl - you might want to check whether you really wanted this type & if so, how it should be handled. To the best of my knowledge/understanding, this type never would've made it through to the DWARF output even prior to this change to remove DISubprograms from retainedType - so this doesn't represent (again, to the best of my understanding) a regression, but exposes a potential problem for your use case, I guess?
Correct. I will cycle back to this, when I find a use-case that depends on this and potentially add the ability to thread this through to DWARF in that case. Let's not hold up this patch because of that though!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80369/new/

https://reviews.llvm.org/D80369