[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

1 comment, perhaps outside the scope of this patch.



================
Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:87
       Ret.emplace_back("CXX11", std::string(Name), "gnu", true);
+      if (Spelling->getValueAsBit("AllowInC"))
+        Ret.emplace_back("C2x", std::string(Name), "gnu", true);
----------------
I guess its a problem for all of these, but why is the last 'true'/'false' (KnownToGCC) not checked from the Spelling?  It has:  let KnownToGCC = 1;.

I would presume that line either is meaningless, or should be used for the true/false bits in here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80836/new/

https://reviews.llvm.org/D80836