[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 29 12:00:32 PDT 2020


arsenm added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14524
+        BuiltinAtomicOp,
+        {Ptr->getType()->getPointerElementType(), Ptr->getType()});
 
----------------
arsenm wrote:
> Should not rely on pointer element type, these are always i32 I think
Nope, they can be i64 (but I assume these aren't overloadable builtins, so would need a separate pair)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80804/new/

https://reviews.llvm.org/D80804





More information about the cfe-commits mailing list