[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus accepted this revision.
Szelethus added a subscriber: balazske.
Szelethus added a comment.
This revision is now accepted and ready to land.

LGTM! I think you could remove the extra parameter, but I don't think this warrants another round of review on my end. However, the dynamic size change seems very unfamiliar to me. @baloghadamsoftware, @balazske, could you take a peek?



================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:237
+      SVal BufDynSize =
+          getDynamicSizeWithOffset(State, BufV, C.getSValBuilder());
+
----------------
You can retrieve `SValBuilder` from `ProgramState`: `State->getStateManager().getSValBuilder()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77066/new/

https://reviews.llvm.org/D77066